Open ctb opened 2 years ago
I think select
wasn't around when I started implementing RevIndex
...
(there is a LOT of fixes to be done in RevIndex
, I don't think it even uses prefetch
, search
and gather
to their full extent)
sure, no huhu or urgency:). But once we have more thorough API tests as in #1936, we could use them to fix up RevIndex
!
In https://github.com/sourmash-bio/sourmash/pull/1936, I'm adding tests for basic features of the
Index
class, andRevIndex
doesn't pass them. (RevIndex
is the rust-based reverse index added in https://github.com/sourmash-bio/sourmash/pull/1238.)When uncommenting the
build_revindex
part of theindex_obj
fixture intests/test_index_protocols.py
from #1936, we see thatselect
with the wrong ksize doesn't work:We might also want to do more specific tests of
RevIndex
intests/test_index.py
and/or add docs on its value, API, and intended use.