consider importing rust code improvements from `sra_search`?

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.

http://sourmash.readthedocs.io/en/latest/

Other

473 stars 80 forks source link

Open ctb opened 2 years ago

ctb commented 2 years ago

in https://github.com/sourmash-bio/sra_search/pull/12, @luizirber defines some functions that seem to me like they would be nice to have in sourmash core -

fn check_compatible_downsample - check if two KerMinHash are compatible w/downsampling
fn prepare_query - downsample a sketch as needed (a replacement for sig.select_sketch

maybe we should consider bringing them in here?

luizirber commented 2 years ago

Note that they were both borrowed from #2230, so technically they will go in at some point. But can also make a smaller PR