sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
455 stars 78 forks source link

Scaled minHash with add_hash_with_abundance #2457

Open damiankao opened 1 year ago

damiankao commented 1 year ago

I am using the add_hash_with_abundance method to add pre-calculated kmers with their abundances. Can this work with a scaled minHash? Will the order or kmers streaming in matter?

ctb commented 1 year ago

Can this work with a scaled minHash?

yes! in fact it only works with a scaled MinHash in theory, although I believe our API lets you do it with a regular (num) MinHash.

Will the order or kmers streaming in matter?

Nope! (Or at least it definitely shouldn't - trust but verify lightly...)

ctb commented 1 year ago

Will the order or kmers streaming in matter?

Nope! (Or at least it definitely shouldn't - trust but verify lightly...)

by which I mean do one or two of the most obvious basic tests, nothing big or robust should be needed.