search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
477 stars 79 forks source link

EXP: Added derives for mem-dbg #3292

Open LucaCappelletti94 opened 3 months ago

LucaCappelletti94 commented 3 months ago

No change to API nor any other aspects are introduced in this pull request.

LucaCappelletti94 commented 3 months ago

@ctb could you kindly start the workflows?

ctb commented 3 months ago

@ctb could you kindly start the workflows?

done! sorry, didn't see the button that needed pushing 😆

LucaCappelletti94 commented 3 months ago

Looking into whether I can make mem-dbg work in 1.65.0

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.75%. Comparing base (bc22970) to head (42a2b8d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## latest #3292 +/- ## ======================================= Coverage 86.75% 86.75% ======================================= Files 137 137 Lines 15920 15920 Branches 2728 2728 ======================================= Hits 13812 13812 Misses 1799 1799 Partials 309 309 ``` | [Flag](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3292/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | Coverage Δ | | |---|---|---| | [hypothesis-py](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `25.40% <ø> (ø)` | | | [python](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `92.37% <ø> (ø)` | | | [rust](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3292/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `62.67% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

LucaCappelletti94 commented 3 months ago

Apparently in mem-dbg there is need for core::mem::offset_of! which is not stable in version 1.65. Will ping this PR if mem-dbg introduces features that make it possible to compile on 1.65.

ctb commented 3 months ago

@LucaCappelletti94 please feel free to leave this PR open 'til then! - and I'll rename it to EXP: which is how I keep track of these things.

luizirber commented 3 months ago

yeah, sorry, we are somewhat conservative with the MSRV, and 1.77 would be a very big bump.

There is a question if we need to be that conservative, because end users don't need the Rust compiler for the Python extension (we have wheels), and we build wheels from latest stable. Most places we track packaging also have newer Rust versions, so that would be an argument to move MSRV faster too.