Closed LucaCappelletti94 closed 3 months ago
@luizirber do check out also this PR please, being an actual bug I believe it is more important
Attention: Patch coverage is 82.45614%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 86.66%. Comparing base (
732fa36
) to head (6c5cd9b
). Report is 68 commits behind head on latest.
Files with missing lines | Patch % | Lines |
---|---|---|
src/core/src/sketch/hyperloglog/estimators.rs | 85.41% | 7 Missing :warning: |
src/core/src/sketch/hyperloglog/mod.rs | 66.66% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
MultiplicityInteger
to handle cleanly without code duplication and the dispatching of different data types given the requested precision at runtime, without introducing marker structs or other distinctive struct attributes. Since the MLE estimation is rather slow, adding an if chain before calling the optimal variant does not add any significant time overhead.