search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
477 stars 79 forks source link

MRG: propagate error from `RocksDB::open` on bad directory #3306

Closed ctb closed 3 months ago

ctb commented 3 months ago

Extracted from https://github.com/sourmash-bio/sourmash/pull/3305

This PR adjusts RevIndex::open to propagate a RocksDBError when opening a non-RocksDB directory.

It also modifies the creation printout in RevIndex::create to distinguish index completion from interim output, for slightly easier debugging.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.67%. Comparing base (38af8fe) to head (3a7abe9). Report is 61 commits behind head on latest.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## latest #3306 +/- ## ========================================== - Coverage 86.69% 86.67% -0.02% ========================================== Files 137 137 Lines 16003 16003 Branches 2728 2728 ========================================== - Hits 13873 13871 -2 - Misses 1821 1823 +2 Partials 309 309 ``` | [Flag](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3306/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | Coverage Δ | | |---|---|---| | [hypothesis-py](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `25.40% <ø> (ø)` | | | [python](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `92.37% <ø> (ø)` | | | [rust](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3306/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `62.89% <100.00%> (-0.07%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚨 Try these New Features:

ctb commented 3 months ago

ready for review & merge @luizirber

bluegenes commented 3 months ago

need to fix rust lints?

ctb commented 3 months ago

thanks!

ctb commented 3 months ago

hmm, will take a look - when I looked at the errors I didn't see much, but I might have missed it in the other stuff!

ctb commented 3 months ago

maybe they were beta? I don't see anything with the non-beta. I'll take it under advisement for the next PR :)

ctb commented 3 months ago

ahh. cargo fmt. sigh. Willfix.