Closed bluegenes closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.40%. Comparing base (
5acf698
) to head (e3c3bb6
). Report is 1 commits behind head on latest.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@sourmash-bio/devs ready for review
oh! I wanted to suggest that you put the suggested changes to behavior in the PR description into new issues, too; I think they require a major version bump?
looks good - esp appreciate the documentation update.
there's some missing code coverage - is this just buggy codecov? I haven't dug in at all.
looks like it was just buggy codecov!
oh! I wanted to suggest that you put the suggested changes to behavior in the PR description into new issues, too; I think they require a major version bump?
now in #3361
Currently, when we generate a
csv_summary
with LINs, we get a summary at every single LIN rank, which is a lot of results and not very helpful. LINgroups are our way of linking the LINs (e.g.14;1;0;0;0;0;0;0;0;0
) to a known name/taxonomic group (e.g. "Phylotype I").This PR changes the behavior of
csv_summary
when alingroup
file is provided, limiting summarized reporting to just the named lingroups. While the output is very similar to thelingroup
output we already have, the most important difference is that the sample name is included in the output, meaning that we get intelligible results when runningtax metagenome
on more than one sample.Prior
tax metagenome
behavior was to always generate alingroup
output file when alingroups
file is provided. Here, I disable that for multiple queries, since the results wouldn't make sense. I do not replace it with another default, but I did add a recommendation to the help + doc.In the future, we could consider changing the default
lingroup
output tocsv_summary
, since it's actually useful for multiple files. Or, we could modify thelingroup
output to include query information.