search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
476 stars 79 forks source link

feat: Implement TryInto to convert Signature and SigStore into KmerMinHash #3348

Closed luizirber closed 1 month ago

luizirber commented 1 month ago

Ref: https://github.com/sourmash-bio/sourmash_plugin_branchwater/pull/467/files#r1797783380

Implement TryInto<KmerMinHash> for Signature and SigStore to avoid having to clone a (potentially big) minhash sketch.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.39%. Comparing base (62f03eb) to head (48d99c5). Report is 1 commits behind head on refactor_rs_downsample.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## refactor_rs_downsample #3348 +/- ## ========================================================== + Coverage 86.48% 92.39% +5.90% ========================================================== Files 137 104 -33 Lines 16060 12909 -3151 Branches 2215 2215 ========================================================== - Hits 13890 11927 -1963 + Misses 1863 675 -1188 Partials 307 307 ``` | [Flag](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3348/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | Coverage Δ | | |---|---|---| | [hypothesis-py](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `25.47% <ø> (ø)` | | | [python](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `92.39% <ø> (ø)` | | | [rust](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3348/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.