search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
476 stars 79 forks source link

remove match_ #3351

Open luizirber opened 1 month ago

luizirber commented 1 month ago

I think match_ is a leftover from the first impl of Index on the rust side, and not needed?

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.43%. Comparing base (11cab80) to head (06867ac).

Files with missing lines Patch % Lines
src/core/src/ffi/index/revindex.rs 0.00% 1 Missing :warning:
src/core/src/index/revindex/mem_revindex.rs 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## latest #3351 +/- ## ========================================== - Coverage 86.45% 86.43% -0.03% ========================================== Files 137 137 Lines 16092 16086 -6 Branches 2219 2219 ========================================== - Hits 13913 13904 -9 - Misses 1872 1875 +3 Partials 307 307 ``` | [Flag](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3351/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | Coverage Δ | | |---|---|---| | [hypothesis-py](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `25.43% <ø> (ø)` | | | [python](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `92.40% <ø> (ø)` | | | [rust](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3351/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `62.03% <81.81%> (-0.17%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ctb commented 1 week ago

This seems ready, yes?

luizirber commented 1 week ago

This seems ready, yes?

sorta, still need to resolve the todo!() in FFI code (for something that is not used in the Python layer, but requires access to the sig...), and without passing the sig in GatherResult I think there is more that can be refactor. Might leave this one for a future PR