sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
476 stars 79 forks source link

Fix clippy lints from 1.83 beta #3357

Closed luizirber closed 1 month ago

luizirber commented 1 month ago

As detected in nightly CI builds: https://github.com/sourmash-bio/sourmash/actions/runs/11375982992/job/31647671463

codspeed-hq[bot] commented 1 month ago

CodSpeed Performance Report

Merging #3357 will degrade performances by 19.61%

Comparing lirber/1.83_beta_fix (d6f145d) with latest (29b7887)

Summary

❌ 4 regressions ✅ 17 untouched benchmarks

:warning: _Please fix the performance issues or acknowledge them on CodSpeed._

Benchmarks breakdown

Benchmark latest lirber/1.83_beta_fix Change
intersection 18.2 µs 20.3 µs -10.01%
intersection_size 15.4 µs 18.3 µs -15.64%
large intersection 9.1 ms 10.6 ms -14.6%
large intersection_size 7.5 ms 9.3 ms -19.61%
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.45%. Comparing base (29b7887) to head (d6f145d). Report is 1 commits behind head on latest.

Files with missing lines Patch % Lines
src/core/src/signature.rs 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## latest #3357 +/- ## ========================================== + Coverage 86.44% 86.45% +0.01% ========================================== Files 137 137 Lines 16070 16069 -1 Branches 2211 2211 ========================================== + Hits 13891 13893 +2 + Misses 1872 1869 -3 Partials 307 307 ``` | [Flag](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3357/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | Coverage Δ | | |---|---|---| | [hypothesis-py](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `25.47% <ø> (ø)` | | | [python](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `92.39% <ø> (ø)` | | | [rust](https://app.codecov.io/gh/sourmash-bio/sourmash/pull/3357/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio) | `62.21% <0.00%> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=sourmash-bio#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.