Closed mr-c closed 1 week ago
Comparing mr-c:rocksdb_0.22.0
(399776a) with latest
(de1a597)
✅ 21
untouched benchmarks
Ah, it would require bumping the minimum rustc
version to 1.66
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.46%. Comparing base (
de1a597
) to head (399776a
). Report is 2 commits behind head on latest.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ah, it would require bumping the minimum
rustc
version to 1.66
This is OK for us, we try to keep the MSRV compatible with what is available in Debian. What is the current Rust available in Debian? I usually check https://packages.debian.org/search?keywords=rustc but it is 503 now, repology says 1.63
for bookworm
and up to 1.82
for trixie
?
Ah, it would require bumping the minimum
rustc
version to 1.66This is OK for us, we try to keep the MSRV compatible with what is available in Debian. What is the current Rust available in Debian? I usually check https://packages.debian.org/search?keywords=rustc but it is 503 now,
On a Debian system, you can run rmadison rustc
(or any Debian package name) to see which versions are in the official archive.
repology says
1.63
forbookworm
and up to1.82
fortrixie
?
And repology is also a decent source, yes 👍🏻
https://packages.ubuntu.com/rustc
Okay, shall I bump the MSRV and retry this PR?
In Debian we are getting a weird error with the older rocksdb
crate, so I wanted to see if the newer version broke anything for sourmash
.
https://paste.debian.net/1334814/
thread 'test_column_family_with_transactiondb' panicked at core/src/panicking.rs:221:5: unsafe precondition(s) violated: ptr::copy_nonoverlapping requires that both pointer arguments are aligned and non-null and the specified memory ranges do not overlap
Seeing if we can upgrade to the latest rocksdb safely.