Closed ctb closed 1 week ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 86.47%. Comparing base (
c6cadb4
) to head (978ae43
). Report is 1 commits behind head on latest.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for review and merge @luizirber !
aaaand as I should have expected: in the branchwater plugin, I get breakages around md5sum tests as well as discovering a few bugs/unhandled situations! Which is good. Just, you know, more work :)
Fixes https://github.com/sourmash-bio/sourmash/issues/3384.
This PR changes
Manifest::select
so that ifscaled
is set in the selection, all matchingRecord
s have their scaled value updated. It also updatesSelection::from_record
to setscaled
to match theRecord
scaled value. In turn, this allowsCollection::sig_from_record
to respect the specifiedscaled
value when loadingSignature
.