Closed ctb closed 6 days ago
Attention: Patch coverage is 50.00000%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 86.46%. Comparing base (
97e7808
) to head (2ce356d
). Report is 1 commits behind head on latest.
Files with missing lines | Patch % | Lines |
---|---|---|
src/core/src/collection.rs | 50.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for review @luizirber @bluegenes !
Addresses https://github.com/sourmash-bio/sourmash/issues/3386
https://github.com/sourmash-bio/sourmash/pull/3387 changed
select
to updateRecord.scaled
to the desired scaled value. This PR changesCollectionSet
to require that allscaled
values be the same, which can now be achieved by runningselect
;).It also adds a new method
Collection::min_max_scaled()
which makes it easy to retrievescaled
for aCollection
.