sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
476 stars 79 forks source link

adjust `ZipStorage::from_file` to pass errors up on bad zip file #3398

Open ctb opened 1 week ago

ctb commented 1 week ago

This line:

                piz::ZipArchive::new(mapping.as_ref().unwrap()).unwrap()

in storage/mod.rs causes panics that would be better handled by the calling function, I think. Or at least it would be nice to have the option :)