Open mr-eyes opened 1 day ago
From slack:
@mr-eyes: Can someone confirm with me that https://ebi-metagenomics.github.io/mgnify-sourmash-component/ does not export the "name" field in signature before I open an issue or PR? signatures exported from mgnify fails to load in sourmash.
@luizirber: for branchwater.sourmash.bio it is not an issue because it only cares about the hashes. likely fixable by setting filename here: https://github.com/sourmash-bio/sourmash/blob/94d37f96e92c5cca85d9b3dcb5b49d52ccca71b8/src/core/src/wasm.rs#L152 using https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.File.html#method.name but better if actually setting the name.
From slack:
@mr-eyes: Can someone confirm with me that https://ebi-metagenomics.github.io/mgnify-sourmash-component/ does not export the "name" field in signature before I open an issue or PR? signatures exported from mgnify fails to load in sourmash.
@luizirber: for branchwater.sourmash.bio it is not an issue because it only cares about the hashes. likely fixable by setting filename here: https://github.com/sourmash-bio/sourmash/blob/94d37f96e92c5cca85d9b3dcb5b49d52ccca71b8/src/core/src/wasm.rs#L152 using https://rustwasm.github.io/wasm-bindgen/api/web_sys/struct.File.html#method.name but better if actually setting the name.