search

sourmash-bio / sourmash

Quickly search, compare, and analyze genomic and metagenomic data sets.
http://sourmash.readthedocs.io/en/latest/
Other
473 stars 80 forks source link

write more tests for sourmash signature module #610

Open ctb opened 5 years ago

ctb commented 5 years ago

There are a variety of things that aren't well tested in the sourmash signature module - e.g. the --ksize and --dna/--protein flags aren't explicitly tested for most of the functions, and the tests of the --track-abundance signatures are not thorough. We should have more!

This is a great entry level task for people interested in contributing!

ctb commented 4 years ago

one specific idea is to pick one of the sourmash sig functions that does not have an inplace test and write one; an in-place test is one that checks to be sure that if a signature file is given as an input, it can still be used as an output with -o.

See test test_sig_rename_2_output_to_same in tests/test_cmd_signature.py for an example of an in-place test.

cat and rename are the only two sig functions with an in-place test. suggest trying to add tests to one or more offlatten, downsample, merge, or subtract.