Open ctb opened 4 years ago
well, good news is that when you add MismatchNum
checking in check_compatible
, you only break 6 tests, all in test__minhash.py
. Not sure if that's because we're not testing different 'num' minhashes from the command line, or what!
...looks like we're not testing it via the command line 😆
https://github.com/sourmash-bio/sourmash/pull/1955 adds in some code for this downsampling.
see https://github.com/dib-lab/sourmash/pull/856#issuecomment-578526048 - there,
ctb
luizirber: