sourmash-bio / sourmash_plugin_branchwater

fast, multithreaded sourmash operations: search, compare, and gather.
GNU Affero General Public License v3.0
15 stars 2 forks source link

examine pyo3 updates to see if we should adjust how we use pyo3 #311

Open ctb opened 6 months ago

ctb commented 6 months ago

per #307, "PyO3 0.21.0 - This release introduces a substantial new direction for PyO3's API".

ctb commented 5 months ago

this seems like one such opportunity - comes up when you build with new pyo3.

warning: use of deprecated method `pyo3::deprecations::GilRefs::<T>::function_arg`: use `&Bound<'_, T>` instead for this function argument
   --> src/lib.rs:307:45
    |
307 | fn sourmash_plugin_branchwater(_py: Python, m: &PyModule) -> PyResult<(...
    |                                             ^
    |
    = note: `#[warn(deprecated)]` on by default