search

sourmash-bio / sourmash_plugin_containment_search

An improved `search --containment` for sourmash
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

request: get an expert to review the ANI code #7

Closed ctb closed 9 months ago

ctb commented 9 months ago

hey @bluegenes if you could run a few quick tests to make sure I'm doing the ANI stuff right, and drop any thoughts and suggestions in this or another issue, I would appreciate it!

bluegenes commented 9 months ago

You're directly using the PrefetchResult ANI values, so I think this should be fine!

https://github.com/sourmash-bio/sourmash_plugin_containment_search/blob/main/src/sourmash_plugin_containment_search.py#L428-L432

genome_containment_ani=result.query_containment_ani,
match_containment_ani=result.match_containment_ani,
average_containment_ani=result.average_containment_ani,
max_containment_ani=result.max_containment_ani,
potential_false_negative=result.potential_false_negative,
ctb commented 9 months ago

I mean, yes, I totally cheated ;). Thx for confirming that there (probably) aren't any hidden gotchas in them thar hills!