sous-chefs / apt

Development repository for the apt cookbook

https://supermarket.chef.io/cookbooks/apt

Apache License 2.0

202 stars 266 forks source link

Backwards Compatibility Break #153

Closed Rockstar04 closed 9 years ago

Rockstar04 commented 9 years ago

https://github.com/opscode-cookbooks/apt/commit/ea17f0bd7650b65337759ee80fa9ecb7799597d1 introduced a potential backwards compatibility break when using the apt_repository lwrp.

Before, the full protocol and port were required to be defined (only when no proxy was used it seems), now that they are automatically added this is causing duplicate protocols and ports to be added causing converge failures.

Rockstar04 commented 9 years ago

I am working on a PR to allow the "new" and "old" ways to define the key server

Rockstar04 commented 9 years ago

154 was merged, if we could get a patch number bump everything will be golden

thommay commented 9 years ago

Pushed and released, thank you!

Rockstar04 commented 9 years ago

No sir, thank you for getting to this so quickly.