apt_repository should honour the components values given, regardless of whether it's a ppa repository

sous-chefs / apt

Development repository for the apt cookbook

https://supermarket.chef.io/cookbooks/apt

Apache License 2.0

202 stars 266 forks source link

apt_repository should honour the components values given, regardless of whether it's a ppa repository #200

Closed et304383 closed 7 years ago

et304383 commented 8 years ago

https://github.com/chef-cookbooks/apt/blob/master/providers/repository.rb#L209

I have no idea what the rationale behind this might be, but this does not work with, for example, the cinnamon repository for 14.04 LTS located at ppa:moorkai/cinnamon

I spent over an hour trying to figure out why the apt_repository resource would not honour the settings I was providing for components.

Ignoring and overriding user input seems like a bad idea in my opinion.

et304383 commented 8 years ago

Any updates here folks? Having to manually run installs for countless repositories because apt_repository isn't honouring my components value is very tedious.

tas50 commented 7 years ago

We've removed the apt_update and apt_repository resources from this cookbook as they were merged into core chef. I'm going to close this issue out now. If you think it's still valid against a new chef-client release please open it up against the chef/chef repo so we can work on it where the code now resides.