sous-chefs / apt

Development repository for the apt cookbook

https://supermarket.chef.io/cookbooks/apt

Apache License 2.0

202 stars 266 forks source link

Remove references to compile_time #262

Closed detjensrobert closed 2 years ago

detjensrobert commented 3 years ago

Description

As unified mode merges compile and converge phases and with Chef 17 requiring unified_mode to be set, references to compile_time do nothing and should be removed.

:warning: Note: this may want to wait for Chef 18 before merging when unified_mode will be on by default.

Issues Resolved

(none)

Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

ramereth commented 2 years ago

@detjensrobert can you please rebase and resolve the conflicts?

@tas50 I'd imagine we want to keep support for this through the current version required for backwards compatibility?

tas50 commented 2 years ago

This change does break the behavior in the cacher recipe. Unified mode has no compile vs. converge, but that doesn't apply to recipes so anything forcing resources to compile mode in a recipe still needs to be there.

detjensrobert commented 2 years ago

I'll close this then.