bump aws-partitions for aws-sdk-core fix

scalp42 commented 5 years ago

Hi folks,

Following the bump of aws-sdk-core to 3.71.0, we also need to bump aws-partitions to at least ~> 1.228.0.

If you don't, the version of aws-partitions is too low and you'll run into the following issue:

    ArgumentError
    -------------
    wrong number of arguments (given 3, expected 2)

    Cookbook Trace:
    ---------------
    /var/chef/cache/cookbooks/aws/libraries/ec2.rb:97:in `create_aws_interface'
    /var/chef/cache/cookbooks/aws/resources/route53_record.rb:153:in `route53_client'
    /var/chef/cache/cookbooks/aws/resources/route53_record.rb:180:in `current_resource_record_set'
    /var/chef/cache/cookbooks/aws/resources/route53_record.rb:35:in `block in class_from_file'

    Resource Declaration:
    ---------------------
    # In /var/chef/cache/cookbooks/wo-dns/recipes/route53.rb

     33:       route53_record node[cookbook_name][recipe_name]['fqdn'] do
     34:         value ec2_hostname
     35:         type 'CNAME'
     36:         ttl 60
     37:         zone_id zone_id
     38:         fail_on_error false
     39:         overwrite true
     40:         action :create
     41:       end
     42:     end

    Compiled Resource:
    ------------------
    # Declared in /var/chef/cache/cookbooks/wo-dns/recipes/route53.rb:33:in `block in from_file'

cc @majormoses @tas50

Tested on our side with 1.237.0 but looks like the lowest it'll work will be 1.228.0.

Let me know if you need anything else.

majormoses commented 5 years ago

Really wish they would follow semver, I am not by a computer right now but I will work on merging and releasing later.

majormoses commented 5 years ago

acceptance into master: https://github.com/chef-cookbooks/aws/pull/399

released: https://supermarket.chef.io/cookbooks/aws/versions/8.1.1

sous-chefs / aws

bump aws-partitions for aws-sdk-core fix #398