search

sous-chefs / aws

Development repository for the aws cookbook
https://supermarket.chef.io/cookbooks/aws
Apache License 2.0
612 stars 554 forks source link

Cannot create tags that start with `aws` #401

Closed tamimkh closed 3 years ago

tamimkh commented 4 years ago

Cookbook version

8.1.1

Chef-client version

14.13.11

Platform Details

Ubuntu 16.04

Scenario:

I am trying to create a set of tag on a resource some of which start with aws. Unfortunately, it looks like due to this bit of code tags starting with aws are stripped out in order to not allow AWS internal tags to be specified. However, according to the documentation it looks like tags that start with aws: are ones that are reserved for AWS internal use. As a result, it seems like this filtering is incorrect and should be removing tags that start with aws: rather then just aws.

I have created a PR that should fix the issue: https://github.com/chef-cookbooks/aws/pull/400

Steps to Reproduce:

  1. Create a sets of tags on a resource some of which starts with aws(ex: aws_service)

Expected Result:

All tags specified on the resource are added to resource in AWS since they are all valid according to the AWS specifications.

Actual Result:

Tags that start with aws are stripped out

welcomebot commented 4 years ago

Hey There It looks like this is the first issue you've filed against the chef-cookbooks project. I'm here to offer you a bit of extra help to make sure we can quickly get back to you. Make sure you've filled out all the fields in our issue template. Make sure you've provided us with the version of chef-client you're running, your operating system and the version of the cookbook. If you're not using the most up to date version of the cookbook then please make sure to update first. Lots of things change between versions even if you're issue isn't listed in the changelog. Finally please give us a detailed description of the issue you're having. The more we know about what you're trying to do, what actually happens, and how you can reproduce the problem, the better.

If you're looking for more immediate troubleshooting help make sure to check out #general on the Chef Community Slack. There's plenty of folks there willing to lend a helping hand. Thanks for the first issue. We hope we can get back to you soon with a solution.

github-actions[bot] commented 3 years ago

Marking stale due to inactivity. Remove stale label or comment or this will be closed in 7 days. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.

github-actions[bot] commented 3 years ago

Closing due to inactivity. If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help! Thanks, Sous-Chefs.