sous-chefs / aws

Development repository for the aws cookbook
https://supermarket.chef.io/cookbooks/aws
Apache License 2.0
610 stars 554 forks source link

Fix ignored Route53 geolocation value #437

Closed mach-kernel closed 1 year ago

mach-kernel commented 3 years ago

Description

If geo_location_country is specified, geo_location_subdivision will always be ignored. And you need to specify both arguments. Our use case is to replicate this Change to make a geolocation rule for Crimea:

<Change>
  <Action>CREATE</Action>
  <ResourceRecordSet>
    <Name>verysupercool.lookatme.example.com</Name>
    <Type>A</Type>
    <SetIdentifier>test</SetIdentifier>
    <GeoLocation>
      <CountryCode>UA</CountryCode>
      <SubdivisionCode>11</SubdivisionCode>
    </GeoLocation>
    <TTL>300</TTL>
    <ResourceRecords>
      <ResourceRecord>
        <Value>127.0.0.1</Value>
      </ResourceRecord>
    </ResourceRecords>
  </ResourceRecordSet>
</Change>

Issues Resolved

#geo_location no longer ignores geo_location_subdivision

Check List

ramereth commented 3 years ago

@mach-kernel please add a CHANGELOG entry

mach-kernel commented 3 years ago

@ramereth added :)

mach-kernel commented 1 year ago

Happy 2023