search

sous-chefs / certificate

Development repository for the certificate cookbook
https://supermarket.chef.io/cookbooks/certificate
73 stars 43 forks source link

Enable use_inline_resources #27

Closed chr4 closed 10 years ago

chr4 commented 10 years ago

This fixes notification for calling resources

When calling certificate_manage, the caller doesn't get notified properly. I restart nginx automatically when a certificate is changed, and the nginx service was not notified

legal90 commented 10 years ago

@atomic-penguin, what about merging this p/r?

atomic-penguin commented 10 years ago

I'll check out pending p/r's on Friday.

tmatilai commented 10 years ago

Oh, it really seems that the notifications have broken once again at some point. I haven't tested this yet, but use_inline_resources should indeed fix it. At the same time it breaks compatibility with Chef 10, which should be mentioned in the requirements in the readme. (Or wrapped in e.g. defined?)

Also new_resource.updated_by_last_action calls would probably be obsolete after this.

Sorry for the drive-by comments, but can't invest time to this right now...