Add 'none' data bag type

sous-chefs / certificate

Development repository for the certificate cookbook

https://supermarket.chef.io/cookbooks/certificate

73 stars 43 forks source link

Add 'none' data bag type #51

Closed martinb3 closed 6 years ago

martinb3 commented 9 years ago

Sometimes it would be nice if I have a strange data bag format, or some other source for data, to be able to directly supply the chain/key/cert content to the resource. Then I could use this cookbook for all of my use cases.

Add a new data_bag_type 'none'
Add TK test suite that fully exercises the new setting
Add documentation with example

atomic-penguin commented 9 years ago

@martinb3 I think this is fine. Needs a little more verbiage in the README to make it clear how this is different than, and not to be confused with, unencrypted data_bag type. Thoughts?

martinb3 commented 9 years ago

@atomic-penguin I'm happy to add additional documentation. I had already put a new line under the list of possible 'data bag type' options, with a line explaining the 'none' option. I've just revised the commit with additional explanation co-located with the example for the 'none' option. Let me know if you think it could use further exposition. Cheers!

mburns commented 8 years ago

@atomic-penguin please review. I think this is merge-able. 👍 😄