sous-chefs / chef-splunk

Development repository for the chef-splunk cookbook

https://supermarket.chef.io/cookbooks/chef-splunk

Apache License 2.0

75 stars 122 forks source link

Align index name validation in custom resources with Splunk docs #217

Closed vnaipaul closed 3 years ago

vnaipaul commented 3 years ago

Description

Usability improvements to the _splunkmonitor and _splunkindex custom resources, accepting valid (user-defined) index names while rejecting invalid index names, as per Splunk's (user-defined) index name requirements and standard internal index names.

Issues Resolved

216

Check List

[x] All tests pass. See TESTING.md for details.
[x] New functionality includes testing.
[x] New functionality has been documented in the README if applicable.

damacus commented 3 years ago

This looks great. Thanks for the PR!

ramereth commented 3 years ago

@vnaipaul can you please add a CHANGELOG entry?

vnaipaul commented 3 years ago

@ramereth I've added a CHANGELOG entry as requested.

kitchen-porter commented 3 years ago

Released as: 9.2.0