search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Restart service instead reload as only few configurations are reloadble. #341

Closed vijaybandari closed 8 years ago

vijaybandari commented 8 years ago

Reload works only for few set of configurations as mentioned here. https://www.consul.io/docs/agent/options.html#reloadable-configuration

https://github.com/johnbellone/consul-cookbook/blob/master/recipes/default.rb#L45 It should be restart instead of reload.

legal90 commented 8 years ago

Hi @vijaybandari That was done intentionally by https://github.com/johnbellone/consul-cookbook/commit/80f4a1ce4edb1638482e2391dabd1ba547ed7fad and https://github.com/johnbellone/consul-cookbook/pull/309 Please, refer to the discussion: https://github.com/johnbellone/consul-cookbook/issues/288

TL;DR: Automatic restart of Consul servers could cause a cluster downtime when you run chef-client simultaneously on your nodes. Also, if Consul version has been changed (upgrade scenario), then Consul servers should be restarted manually, according to the upgrade manual.

vijaybandari commented 8 years ago

Thanks @legal90 , now it makes sense.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.