sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Installation archive URL should be configurable #342

Closed sonnysideup closed 8 years ago

sonnysideup commented 8 years ago

The archive URL is hardcoded to the value "https://releases.hashicorp.com/consul/%{version}/%{basename}" inside the default_archive_url class method defined by both the binary and webui installation resources.

Doesn't it make sense to move the base URL and checksums into attribute values so that cookbook consumers can cache copies of these packages where they see fit (e.g. S3, on-prem NAS, etc...)?

stanchan commented 8 years ago

I believe that this can be overridden by an inversion option. Not sure how it is being passed to the resource. Can anyone provide a sample of this?

johnbellone commented 8 years ago
default['consul']['options']['archive_url'] = 'https://hashicorp.mirror.corporate.com/consul/%{version}/%{basename}'
sonnysideup commented 8 years ago

thank you.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.