search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Cut a new release of this cookbook? #347

Closed jeffbyrnes closed 8 years ago

jeffbyrnes commented 8 years ago

The last release of this cookbook was May 17, and quite a bit of good stuff has been added since then, as well as the release of Consul 0.7.0.

It’d be great to see a new version cut & pushed to Supermarket.

Notable changes:

a plenty of fixes.

Perhaps v3.0.0, since the change in the Consul version is potentially breaking?

johnbellone commented 8 years ago

Why is the change breaking?

jeffbyrnes commented 8 years ago

Going along with Consul’s own versioning, a change from the 0.6.x series to 0.7.x is potentially breaking (as per SemVer), and, if an end-user of this cookbook has not set node['consul']['version'] themselves, their systems will be upgraded to Consul 0.7.0, which may be undesirable.

As such, it seems polite & in-line with SemVer to bump this cookbook’s major version, for anyone whose wrapper is set like so: depends 'consul', '~> 2.0', which is not uncommon.

johnbellone commented 8 years ago

Yes, but the version of the cookbook is independent of the Consul project. We've traditionally only bumped the major version of the cookbook when there is a backwards incompatibility in the cookbook's code itself (e.g. when we added the consul installation resource).

jeffbyrnes commented 8 years ago

I’m aware that it’s independent, but I think there’s a responsibility to the relationship between what version of Consul this cookbook installs by default, and what that might mean for an operator depending on this cookbook.

I would consider upgrading someone’s copy of Consul to be potentially breaking.

Is there some reason not to bump the major number? Is there some negative I’m unaware of, other than operators needing to update their own wrappers?

Hoverbear commented 8 years ago

The 'latest' release on Github was actually in February: https://github.com/johnbellone/consul-cookbook/releases despite there being 6 newer ones.

We're also quite interested in getting a new release cut.

Hoverbear commented 8 years ago

@eyalzek Please don't use comments for +1ing things. Github specifically added a reaction flag for this purpose. If you want to stay up to date you can use the "Subscribe" button on the side.

johnbellone commented 8 years ago

The last release of the cookbook was 2.1.3 in May. I'm going to release the current master as 2.2.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.