search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Avoid creating broken link on windows #357

Closed kamaradclimber closed 8 years ago

kamaradclimber commented 8 years ago

Change-Id: I45ae9496ab01f2430d056af9b084d0c9e7a91564

legal90 commented 8 years ago

@kamaradclimber Thanks! But I'd recommend using the built-in helper windows? instead:

not_if { windows? }

That's just a common practice used in this cookbook as well as in Chef Client itself

kamaradclimber commented 8 years ago

ok thanks for the tip

codecov-io commented 8 years ago

Current coverage is 59.44% (diff: 100%)

No coverage report found for master at d60cc91.

Powered by Codecov. Last update d60cc91...7a752b8

kamaradclimber commented 8 years ago

done

legal90 commented 8 years ago

LGTM. I'm gonna merge this PR since the only failed build is ChefSpec, which is not relevant. @kamaradclimber Thanks for the contribution!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.