WIP: Fix "webui" installation with poise_archive

sous-chefs / consul

Development repository for the consul cookbook

https://supermarket.chef.io/cookbooks/consul

Apache License 2.0

192 stars 244 forks source link

WIP: Fix "webui" installation with poise_archive #358

Closed legal90 closed 7 years ago

legal90 commented 8 years ago

Work in progress: I try to make unit test passing, but seems like they are still failing. Any suggestions are welcome.

@johnbellone @Ginja What do you think - is it still reasonable to support :webui provider for consul_installation resource if there is a builtin webui in Consul 0.6.1+ ? FYI: the current implementation of :webui provider is also incompatible with Windows.

codecov-io commented 7 years ago

Current coverage is 52.79% (diff: 18.18%)

No coverage report found for master at 2a49cac.

Powered by Codecov. Last update 2a49cac...1f81c43

johnbellone commented 7 years ago

I am cool with deprecating the provider and bumping the major version in doing so.

legal90 commented 7 years ago

Yes, it sounds good. But at the moment this PR is superseded by https://github.com/johnbellone/consul-cookbook/pull/378, so I'd close it.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.