search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Added missing attributes #359

Closed teluka closed 8 years ago

freimer commented 8 years ago

I haven't had a chance to look deep into the build failures yet, but these appear cosmetic to the change. zipfile missing, space at end of line, some package install failure on Debian. Any chance of getting this fixed up and merged soon? I'll need at least the performance attribute.

Any thought of turning this into a new-style resource, instead of a LWRP? I can see the value of validating the config options, but this also requires this cookbook to closely track the consul product. If it were a new-style resource then it could include a JSON schema and use that to check, and also have an option to turn validity checking off if the product includes some new feature. That would allow the cookbook to still work without having to be immediately updated. Just some thoughts...

codecov-io commented 8 years ago

Current coverage is 59.39% (diff: 66.66%)

No coverage report found for master at 14056b2.

Powered by Codecov. Last update 14056b2...bc36302

legal90 commented 8 years ago

I've appended your branch with 8e1396f, adding more attributes appeared in Consul v0.7.0. @matelukas, thank you for the contribution!

freimer commented 8 years ago

Do we need to bump the version in metadata.rb to 2.2.1?

legal90 commented 8 years ago

IMO, the version bump should happen simultaneously with a new version release, which is up to @johnbellone.

freimer commented 8 years ago

OK, gotcha. Thanks!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.