Four failing RSpec tests in master branch

sous-chefs / consul

Development repository for the consul cookbook

https://supermarket.chef.io/cookbooks/consul

Apache License 2.0

192 stars 244 forks source link

Closed gdavison closed 7 years ago

gdavison commented 7 years ago

There are four failing RSpec tests in master:

rspec ./test/spec/recipes/default_spec.rb:30 # consul::default with create_service_user disabled does not try to create the user
rspec ./test/spec/libraries/consul_installation_webui_spec.rb:31 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation
rspec ./test/spec/libraries/consul_installation_webui_spec.rb:25 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation
rspec ./test/spec/libraries/consul_installation_webui_spec.rb:19 # ConsulCookbook::Provider::ConsulInstallationWebui webui installation

This appears to be blocking a number of PRs

gdavison commented 7 years ago

It looks like the WebUI tests have to be marked pending individually, which resolves three of the tests.

For the user test, calling default_attributes does not seem to be passing the attributes to the recipe during the test. I also added some tests in https://github.com/paybyphone/consul-cookbook/commit/e21f6493a397a3384a7ecb512ebebb40312992c5 to ensure the correct users are being created. It is currently creating the consul user in each case.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.