sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Can't use the cookbook with Chef 11 because of firewall cookbook #392

Closed barrowkwan closed 7 years ago

barrowkwan commented 7 years ago

Hi, I am trying to use the cookbook Chef11 but got error with firewall cookbook because firewall cookbook 2.0.0 and above can only be used with Chef 12. I wonder if consul 2.0 and above has to use firewall cookbook 2.0.0 or can use firewall cookbook with an earlier version?

legal90 commented 7 years ago

IMO, I would remove "firewall" dependency from this cookbook (and the related block from the "default" recipe). That is an important thing, but is really specific and depends on the platform and the concrete use case, so it's better to handle it in a wrapper cookbook.

@johnbellone, what do you think about this?

johnbellone commented 7 years ago

I agree with @legal90 - this should be managed inside of a wrapper such as consul-cluster cookbook. But I want to stress that outside of this, @barrowkwan should note that Chef 11 is not supported by this cookbook. It may work, but that client version is very old.

johnbellone commented 7 years ago

This also constitutes a major version change.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.