sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Remove firewall dependency #395

Closed legal90 closed 7 years ago

legal90 commented 7 years ago

It was discussed in https://github.com/johnbellone/consul-cookbook/issues/392. According to the best practices for application cookbooks, it's better to manage firewall setting outside of this cookbook.

NB! This PR introduces breaking changes. It is recommended to merge it alongside with the major version bump.

Closes #392

codecov-io commented 7 years ago

Current coverage is 69.17% (diff: 100%)

No coverage report found for master at b2fbd5f.

Powered by Codecov. Last update b2fbd5f...f8fb12d

legal90 commented 7 years ago

397 should fix the TravisCI builds

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.