Closed kamaradclimber closed 7 years ago
I've fixed tests (I thought I had actually)
:exclamation: No coverage uploaded for pull request base (
master@558baf3
). Click here to learn what that means.
@@ Coverage Diff @@
## master #411 +/- ##
=========================================
Coverage ? 66.86%
=========================================
Files ? 7
Lines ? 341
Branches ? 0
=========================================
Hits ? 228
Misses ? 113
Partials ? 0
Impacted Files | Coverage Δ | |
---|---|---|
libraries/helpers.rb | 54.05% <ø> (ø) |
|
libraries/consul_config.rb | 97.39% <100%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 558baf3...b9f7fe5. Read the comment docs.
tests are really flaky, I'll try to make them pass but they should be corrected.
@kamaradclimber I've just tried to rebase your branch onto current master state to get everything fixed. Don't you mind I finish it and merge this PR then?
go ahead @legal90. I was quite suprised my branch has been rebased actually :)
Thanks for your help
Thank you for the contribution!
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Simple sort compare key & values. It fails for hash values.
For instance:
will raise
ArgumentError: comparison of Array with Array failed
.Sorting by keys is sufficient
Fix #410
Change-Id: Ieaf05a019c4d636ae8457046ee4e3bf8f697296a