sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Consul 0.7.5 & Windows Fixes #421

Closed Ginja closed 7 years ago

Ginja commented 7 years ago
codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b31d1e7). Click here to learn what that means. The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #421   +/-   ##
=========================================
  Coverage          ?   61.97%           
=========================================
  Files             ?        7           
  Lines             ?      355           
  Branches          ?        0           
=========================================
  Hits              ?      220           
  Misses            ?      135           
  Partials          ?        0
Impacted Files Coverage Δ
libraries/consul_service_windows.rb 23.72% <20%> (ø)
libraries/consul_service.rb 56.25% <25%> (ø)
libraries/helpers.rb 47.36% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b31d1e7...cb8974d. Read the comment docs.

legal90 commented 7 years ago

@Ginja Could you please also fix the cookstyle offense? https://travis-ci.org/johnbellone/consul-cookbook/jobs/220580777#L504-L506

legal90 commented 7 years ago

@Ginja Thank you! I've rebased your branch in order to fix merge conflict. TravisCI failure should be fixed by #424

Ginja commented 7 years ago

Thanks, @legal90!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.