sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Support nssm cookbook 3.0 #422

Closed Annih closed 7 years ago

Annih commented 7 years ago

Nssm cookbook version 3.0 has been release with a breaking change. The 'params' property has been renamed in 'parameters' for Chef 13 compat.

This code use 'parameters' if the resource expose this property and 'params' otherwise.

Cc: @aboten

codecov-io commented 7 years ago

Codecov Report

Merging #422 into master will decrease coverage by 8.35%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #422      +/-   ##
==========================================
- Coverage   70.89%   62.53%   -8.36%     
==========================================
  Files           7        7              
  Lines         347      347              
==========================================
- Hits          246      217      -29     
- Misses        101      130      +29
Impacted Files Coverage Δ
libraries/consul_service_windows.rb 23.21% <0%> (-0.43%) :arrow_down:
libraries/consul_definition.rb 44.44% <0%> (-47.23%) :arrow_down:
libraries/consul_execute.rb 55% <0%> (-45%) :arrow_down:
libraries/helpers.rb 48.64% <0%> (-5.41%) :arrow_down:
libraries/consul_config.rb 97.5% <0%> (-0.03%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6689d41...cb31444. Read the comment docs.

legal90 commented 7 years ago

@Annih Thank you for the contribution!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.