search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

add support for specifying the raft protocol version #425

Closed poblahblahblah closed 7 years ago

poblahblahblah commented 7 years ago

consul 0.8.0 includes some autopilot features look really nice. In order to enable these you need to specify the raft protocol version.

This change allows us to do that.

codecov-io commented 7 years ago

Codecov Report

Merging #425 into master will increase coverage by 12.51%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #425       +/-   ##
===========================================
+ Coverage   58.38%   70.89%   +12.51%     
===========================================
  Files           7        7               
  Lines         346      347        +1     
===========================================
+ Hits          202      246       +44     
+ Misses        144      101       -43
Impacted Files Coverage Δ
libraries/consul_config.rb 97.52% <100%> (+20.02%) :arrow_up:
libraries/helpers.rb 54.05% <0%> (+5.4%) :arrow_up:
libraries/consul_definition.rb 91.66% <0%> (+47.22%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7b9b75c...2e5d12f. Read the comment docs.

poblahblahblah commented 7 years ago

@legal90 sounds good - PR updated to remove the default.

legal90 commented 7 years ago

@poblahblahblah Thank you!

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.