sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Update unit tests configuration #426

Closed legal90 closed 7 years ago

legal90 commented 7 years ago

Currently we have unit tests failed because of a cheffish gem conflict (is required by chef-dk gem). This PR removes some unnecessary gem dependencies and introduces Chef Delivery CLI for running tests, like Chef Software does that for their cookbooks.

codecov-io commented 7 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@da7f406). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #426   +/-   ##
=========================================
  Coverage          ?   69.46%           
=========================================
  Files             ?        7           
  Lines             ?      357           
  Branches          ?        0           
=========================================
  Hits              ?      248           
  Misses            ?      109           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update da7f406...0324cfa. Read the comment docs.

legal90 commented 7 years ago

@johnbellone Do we really need this codecov integration in CI? It doesn't look helpful at the moment, IMO.

johnbellone commented 7 years ago

@legal90 It should be disabled as of right now.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.