Adding the option to modify the permissions on the consul conf.d dire…

[MichaelKueller]

…ctory.

[codecov-io]

Codecov Report

Merging #430 into master will decrease coverage by 7.79%. The diff coverage is 50%.

@@            Coverage Diff            @@
##           master     #430     +/-   ##
=========================================
- Coverage   62.82%   55.02%   -7.8%     
=========================================
  Files           7        7             
  Lines         347      358     +11     
=========================================
- Hits          218      197     -21     
- Misses        129      161     +32

Impacted Files	Coverage Δ
libraries/consul_config.rb	77.86% <50%> (-19.66%)	:arrow_down:
libraries/consul_service.rb	56.25% <0%> (-1.53%)	:arrow_down:
libraries/helpers.rb	47.36% <0%> (-1.29%)	:arrow_down:
libraries/consul_service_windows.rb	22.95% <0%> (-0.69%)	:arrow_down:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f01a12d...3825f31. Read the comment docs.

[MichaelKueller]

@Ginja could you readd your comments to the pull request please. I wanted to have two seperate pull requests for the two changes I made, as they are not related to each other.

[legal90]

@MichaelKueller Could you please give an example of the use case - when people might want to set the custom permission mode for this dir?

[MichaelKueller]

@legal90 yes, sure. In our case we have a user different than the consul user, that we use to perform deployments. During the deployment this user writes the service_definition_file into /etc/consul/conf.d directory. With the current persmissions (0755) this is not possible, as only the consul user could do so. In this case it is very helpful if these permissions are configurable.

[legal90]

Thanks, @MichaelKueller! Now it makes sense 👍

@johnbellone, Do you have any concerns to get it merged?

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.