search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Remove _wait_for_listening hook from sysvinit script #444

Closed legal90 closed 7 years ago

legal90 commented 7 years ago

This PR partially reverts #433 . Reasons:

1) The root issue has been fixed by another solution: #443 2) We can't use consul info call in init script, because it doen't work in Consul 0.8+ with ACL enabled (https://github.com/johnbellone/consul-cookbook/pull/434#issuecomment-303654809)

codecov-io commented 7 years ago

Codecov Report

Merging #444 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #444   +/-   ##
=======================================
  Coverage   67.03%   67.03%           
=======================================
  Files           7        7           
  Lines         358      358           
=======================================
  Hits          240      240           
  Misses        118      118

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 95be769...3dccaa7. Read the comment docs.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.