search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Remove default attributes ['config']['owner'] and ['config']['group'] #446

Closed legal90 closed 7 years ago

legal90 commented 7 years ago

These attributes are redundant in the default.rb attribute file because they cause a confusion about how the default values of consul_config's owner and group params are actually determined.

Due to Poise inversion options, the node's attribute will always have a precedence. They are designed to be used by cookbook end-users in their wrapper cookbooks.

We already have default values defined in the resource itself: https://github.com/johnbellone/consul-cookbook/blob/eebc1299cefb6d766218904ea372566cc84bf373/libraries/consul_config.rb#L21-L26

Default values of ['service_owner'] and ['service_group'] are "consul" too, so we can remove ['config']['owner'] and ['config']['group'] without any effect.

Fixes #405

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.