search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Fix consul application path on Windows #449

Closed slavirok closed 7 years ago

slavirok commented 7 years ago

There was a hard coded Unix path which was being used on Windows Installation.

legal90 commented 7 years ago

Hi @slavirok ! Could you please evaluate - what was the issue you have faced with? Do you install Consul from a package (msi?), or just as a binary? Sharing the recipe code would be great.

legal90 commented 7 years ago

FYI: package provider for consul_installation resource has UNIX-specific path hard coded just because it doesn't support Windows yet. The expected behavior for Windows is using the default provider (e.q. binary), as it is done in consul::default recipe: https://github.com/johnbellone/consul-cookbook/blob/eebc1299cefb6d766218904ea372566cc84bf373/recipes/default.rb#L23-L40

slavirok commented 7 years ago

Hi @legal90 this is my recipe:

include_recipe 'consul::default'

consul_service 'consul' do
  notifies :restart, 'service[consul]'
end

service 'consul' do
  action :nothing
end
legal90 commented 7 years ago

@slavirok This recipe looks wrong. You should not declare consul_service resource since it is already declared in 'consul::default' recipe.

What is the expected behavior? Do you want to restart (instead of reload) the consul service every time the /etc/consul/consul.json is changed?

legal90 commented 7 years ago

Closing this PR since it's not relevant to the issue described here.

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.