Closed gdavison closed 7 years ago
Most of the foodcritic
failures are in code not touched by this PR
Merging #452 into master will decrease coverage by
4.33%
. The diff coverage is50%
.
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 62.11% 57.77% -4.34%
==========================================
Files 7 7
Lines 359 360 +1
==========================================
- Hits 223 208 -15
- Misses 136 152 +16
Impacted Files | Coverage Δ | |
---|---|---|
libraries/consul_service_windows.rb | 22.95% <0%> (ø) |
:arrow_up: |
libraries/consul_service.rb | 57.14% <100%> (+0.89%) |
:arrow_up: |
libraries/consul_watch.rb | 48.48% <0%> (-42.43%) |
:arrow_down: |
libraries/helpers.rb | 47.36% <0%> (-5.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a552ae7...aa024b5. Read the comment docs.
Lol, coverage went down when I added tests
@legal90, any chance you could take a look at this? It's blocking ACL use on Windows.
@gdavison Thank you! LGTM
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
When a master ACL is set on the cluster, the service reload requires the ACL token; this is now added to the Windows service as well.
I've added Windows 2016 to the testing suite, as well as using Matt Wrock's Vagrant boxes as the default for Windows. This means that developers aren't stuck with the choices of rolling their own Windows boxes or skipping testing on Windows.