sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Add enable_script_checks config param #462

Closed bdwyertech closed 7 years ago

bdwyertech commented 7 years ago

Script-based health checks are now opt-in -- Need to make this configurable to run Consul 0.9

https://www.hashicorp.com/blog/consul-0-9/

codecov-io commented 7 years ago

Codecov Report

Merging #462 into master will decrease coverage by 7.59%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #462     +/-   ##
=========================================
- Coverage   64.73%   57.14%   -7.6%     
=========================================
  Files           7        7             
  Lines         363      364      +1     
=========================================
- Hits          235      208     -27     
- Misses        128      156     +28
Impacted Files Coverage Δ
libraries/consul_config.rb 78.74% <100%> (+0.16%) :arrow_up:
libraries/consul_definition.rb 44.44% <0%> (-47.23%) :arrow_down:
libraries/consul_watch.rb 48.48% <0%> (-42.43%) :arrow_down:
libraries/helpers.rb 47.36% <0%> (-5.27%) :arrow_down:
libraries/consul_service_windows.rb 31.14% <0%> (+8.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 059dc4a...49ef791. Read the comment docs.

legal90 commented 7 years ago

@bdwyertech Thank you!

ghost commented 7 years ago

I'm hoping to see this change included in a new release to Chef Supermarket (maybe v3.1.0). I'd like to upgrade to consul 0.9 for the shiny new catalog option the command line, but I'm holding off until the next release of this cookbook because we depend on script checks. It's not urgent and not breaking anything in my environment, I just like consul a lot.

Any chance of getting a new release soon?

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.