search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

Leverage nssm 4.0.0 and remove obsolete code #464

Closed Annih closed 7 years ago

Annih commented 7 years ago

NSSM cookbook version 4 improved its parameter handling and idempotency. No need to do weird quoting (this is a small breaking change!)

This replaces #455 and should fix #454 Cc. @aboten

Annih commented 7 years ago

Hum tests are failing due to berkshelf/solve#67 this should be resolved with next Berkshelf release :(

Annih commented 7 years ago

Ok travis test fixed thanks to recent Berkshelf release. I don't understand the code coverage failure...

Annih commented 7 years ago

@legal90 any feedback would be appreciate to improve this PR and possibly get it merge.

Thanks!

legal90 commented 7 years ago

@Annih, Thank you for your contribution! I'm sorry for a late response - I don't work with Chef and Consul anymore, that's why I'm not so active here as before.

I've rebased your branch (because of the merge conflict) and verified it via Kitchen. It works great, thank you! 👍

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.