search

sous-chefs / consul

Development repository for the consul cookbook
https://supermarket.chef.io/cookbooks/consul
Apache License 2.0
192 stars 244 forks source link

add flags attribute #466

Closed sigmatechnica closed 7 years ago

sigmatechnica commented 7 years ago

Consul needs runtime flags for some stuff (like running the UI). This PR adds a flags attribute that allows that, and by default sets to to nothing.

legal90 commented 7 years ago

Hi @sigmatechnica, In this cookbook, we try to keep the only one way for passing configuration parameters to Consul agent. It's the main configuration file, managed by consul_config resource.

In particular, UI could be enabled by setting an attribute:

node.default['consul']['config']['ui'] = true

So, I would prefer to do not have flag support here, to avoid confusions when the same parameter could be defined in multiple places.

@johnbellone @Ginja, what do you think about it?

sigmatechnica commented 7 years ago

Aah didn't find node.default['consul']['config']['ui'] documented anywhere so invented my own way. agree, does make this a bit pointless

sigmatechnica commented 7 years ago

closing as it's unneeded (and fails CI checks for centos 7 anyway)

lock[bot] commented 4 years ago

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.